Skip to content

Display point in base58#305

Merged
ax0 merged 5 commits intomainfrom
feat/display-point
Jun 23, 2025
Merged

Display point in base58#305
ax0 merged 5 commits intomainfrom
feat/display-point

Conversation

@ed255
Copy link
Collaborator

@ed255 ed255 commented Jun 20, 2025

Depends on #304

Implement Display for Point like this:

  • In alternate mode, show the x, u coordinates using the display of the extension field
  • In normal mode if the point is in the subgroup display the u coord in base58. If not in the subgrup display the x and u coords concatenated in base58.

Implement the serialization/deserialization using the base58 encoding.

The reason to use base58 VS base64 is to make it easier to select an entire public key and make it easy to compare two public keys or even read them aloud.

Copy link
Collaborator

@ax0 ax0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ax0 ax0 merged commit d5da9d8 into main Jun 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants